Skip to content

MAINT update langugage-data dependency#1076

Merged
gwarmstrong merged 3 commits intomainfrom
georgea/update-langcodes
Dec 5, 2025
Merged

MAINT update langugage-data dependency#1076
gwarmstrong merged 3 commits intomainfrom
georgea/update-langcodes

Conversation

@gwarmstrong
Copy link
Collaborator

@gwarmstrong gwarmstrong commented Dec 5, 2025 •
edited by coderabbitai bot
Loading

It appears this was implicitly required before but it is causing issues on the CI so we will explicitly require it

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated package dependencies.

Note: This release contains no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@gwarmstrong
MAINT update langugage-data dependency
1818d68 
Signed-off-by: George Armstrong <georgea@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

📝 Walkthrough

Walkthrough

Added the language-data Python package to the project's main requirements file. This is a straightforward dependency addition affecting only the requirements manifest.

Changes

Cohort / File(s) Summary
Dependency Addition
requirements/main.txt		 Added language-data package to project dependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line addition to a requirements file
  • No logic changes or structural modifications
  • Verify package name and any version constraints if applicable

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title contains a typo ('langugage' instead of 'language') and is only partially related to the changeset—it refers to updating a dependency, which is accurate, but the specific focus is on making an implicit requirement explicit in the requirements file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch georgea/update-langcodes
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc1dcc and 1818d68.

📒 Files selected for processing (1)
  • requirements/main.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: gpu-tests-qwen
  • GitHub Check: pre-commit
  • GitHub Check: unit-tests
🔇 Additional comments (1)
requirements/main.txt (1)

32-32: LGTM. Properly resolves the implicit dependency issue.

The language-data package is usually installed as a dependency of langcodes, making it a valid implicit transitive dependency that this PR now makes explicit. The placement is correct (alphabetically between langcodes and litellm), and the lack of version pinning is consistent with other unpinned dependencies in the file and is appropriate given that the latest version (1.4.0) was released Nov 28, 2025. This change directly addresses the CI failures noted in the PR objective.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gwarmstrong
cachebust
99262ac 
Signed-off-by: George Armstrong <georgea@nvidia.com>
@gwarmstrong gwarmstrong merged commit c1bf755 into main Dec 5, 2025
6 of 7 checks passed
@gwarmstrong gwarmstrong deleted the georgea/update-langcodes branch December 5, 2025 06:16
Jorjeous pushed a commit that referenced this pull request Dec 11, 2025
@gwarmstrong @Jorjeous
MAINT update langugage-data dependency (#1076)
e853995 
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Dec 12, 2025
@gwarmstrong @wasiahmad
MAINT update langugage-data dependency (#1076)
8fb2c1a 
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
Froxyy-dev pushed a commit that referenced this pull request Dec 12, 2025
@gwarmstrong @Froxyy-dev
MAINT update langugage-data dependency (#1076)
9014265 
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: Mateusz Winiarek <mwiniarek@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Dec 19, 2025
@gwarmstrong @wasiahmad
MAINT update langugage-data dependency (#1076)
a31b381 
Signed-off-by: George Armstrong <georgea@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Dec 19, 2025
@gwarmstrong @wasiahmad
MAINT update langugage-data dependency (#1076)
dd376d6 
Signed-off-by: George Armstrong <georgea@nvidia.com>

Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
wasiahmad pushed a commit that referenced this pull request Feb 4, 2026
@gwarmstrong @wasiahmad
MAINT update langugage-data dependency (#1076)
6594d4c 
Signed-off-by: George Armstrong <georgea@nvidia.com>
dgtm777 pushed a commit that referenced this pull request Mar 18, 2026
@gwarmstrong
MAINT update langugage-data dependency (#1076)
686199f 
Signed-off-by: George Armstrong <georgea@nvidia.com>
dgtm777 pushed a commit that referenced this pull request Mar 18, 2026
@gwarmstrong @dgtm777
MAINT update langugage-data dependency (#1076)
dd99717 
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: dgitman <dgitman@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run GPU tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gwarmstrong